test: add end-to-end routing coverage for collectors commands and derivator

This commit is contained in:
Ilgiz Kalmetyev 2026-04-17 14:12:40 +05:00
parent 7c319c8cbf
commit 44b267b9bb
3 changed files with 324 additions and 0 deletions

View File

@ -0,0 +1,110 @@
from __future__ import annotations
from pathlib import Path
from agent.app import load_application
from agent.collectors import FakeJournalBackend, JournalCollector
from agent.utils.toml_loader import loads_toml
ROOT = Path(__file__).resolve().parents[2]
FIXTURES = ROOT / "tests" / "fixtures"
def _journal_config(*, outbox_enabled: bool) -> dict[str, object]:
mark_block = ""
if outbox_enabled:
mark_block = """
[[collectors.journal.marks]]
when.field = "event_type"
when.op = "eq"
when.value = "wifi.raw.journal.wpa_supplicant"
add.workflow_tags = ["wifi", "journal"]
add.labels.site = "warehouse-a"
add.routing.outbox_enabled = true
"""
return loads_toml(
f"""
[collectors.journal]
enabled = true
mode = "head"
source_name = "systemd-journal"
[[collectors.journal.filters]]
field = "_COMM"
op = "eq"
value = "wpa_supplicant"
action = "keep"
reason = "keep wpa_supplicant journal messages"
{mark_block}
"""
)
def _journal_backend() -> FakeJournalBackend:
return FakeJournalBackend(
entries=[
{
"cursor": "c-1",
"message": "CTRL-EVENT-CONNECTED",
"fields": {
"_SYSTEMD_UNIT": "wpa_supplicant.service",
"_COMM": "wpa_supplicant",
"PRIORITY": "6",
"MESSAGE": "CTRL-EVENT-CONNECTED",
},
"realtime_ns": 1_700_000_000_000_000_000,
"source_name": "wpa-supplicant",
}
]
)
def test_journal_collector_routes_envelope_through_director_cache_only() -> None:
app = load_application(config_path=FIXTURES / "cli-basic.toml", load_env_file=False)
collector = JournalCollector.from_toml(
_journal_config(outbox_enabled=False),
collector_name="journal",
backend=_journal_backend(),
event_sink=app._collector_envelope_sink,
trace_sink=app._ingest_trace_sink,
)
collector.start()
outcomes = collector.drain_pending()
assert len(outcomes) == 1
assert outcomes[0].accepted is True
assert collector.current_cursor() == "c-1"
assert app.cache.head(1).records[0].type == "wifi.raw.journal.wpa_supplicant"
assert app.outbox.stats().size == 0
stages = [record["stage"] for record in app.ingest_trace.snapshot().records]
assert "runtime.ingest.begin" in stages
assert "director.ingest.begin" in stages
assert "director.cache.append" in stages
assert "director.outbox.enqueue" not in stages
def test_journal_collector_routes_envelope_through_director_cache_and_outbox() -> None:
app = load_application(config_path=FIXTURES / "cli-basic.toml", load_env_file=False)
collector = JournalCollector.from_toml(
_journal_config(outbox_enabled=True),
collector_name="journal",
backend=_journal_backend(),
event_sink=app._collector_envelope_sink,
trace_sink=app._ingest_trace_sink,
)
collector.start()
outcomes = collector.drain_pending()
assert len(outcomes) == 1
assert outcomes[0].accepted is True
assert app.cache.head(1).records[0].type == "wifi.raw.journal.wpa_supplicant"
assert app.outbox.stats().size == 1
assert app.outbox.items()[0].seq_no == 1
records = app.ingest_trace.snapshot().records
assert any(record.get("origin") == "collector" for record in records)
assert any(record.get("outbox_applied") is True for record in records)
assert any(record["stage"] == "director.outbox.enqueue" for record in records)

View File

@ -0,0 +1,71 @@
from __future__ import annotations
from pathlib import Path
from agent.app import load_application
from agent.commands import (
CommandCoordinator,
CommandOriginKind,
CommandRequest,
CommandResult,
CommandState,
CommandTargetKind,
)
ROOT = Path(__file__).resolve().parents[2]
FIXTURES = ROOT / "tests" / "fixtures"
class _RecordingRouter:
def __init__(self) -> None:
self.calls: list[str] = []
def supports(self, request: CommandRequest) -> bool:
return request.command_type.startswith("wpa.")
def execute(self, request: CommandRequest) -> CommandResult:
self.calls.append(request.command_id)
return CommandResult.from_request(
request,
state=CommandState.SUCCEEDED,
accepted=True,
success=True,
message=f"ok:{request.command_id}",
executor_name="router",
started_mono_ns=1,
finished_mono_ns=2,
)
def _request() -> CommandRequest:
return CommandRequest(
command_id="cmd-1",
command_type="wpa.status",
origin_kind=CommandOriginKind.CLI,
origin_id="cli",
target_kind=CommandTargetKind.WPA_CTRL,
target_id="wlp3s0",
)
def test_command_submission_routes_results_through_director() -> None:
app = load_application(config_path=FIXTURES / "cli-basic.toml", load_env_file=False)
router = _RecordingRouter()
app.command_coordinator_runtime = CommandCoordinator(
router=router,
sink=app._on_command_result,
)
submission = app.submit_command(_request(), now_mono_ns_value=100)
assert submission.accepted is True
assert submission.emitted_count == 2
assert router.calls == ["cmd-1"]
assert app.cache.head(2).records[0].type == "control.command.started"
assert app.cache.head(2).records[1].type == "control.command.succeeded"
assert app.outbox.stats().size == 2
records = app.ingest_trace.snapshot().records
assert any(record.get("origin") == "command" for record in records)
assert any(record["stage"] == "director.outbox.enqueue" for record in records)
assert sum(1 for record in records if record.get("origin") == "command") == 4

View File

@ -0,0 +1,143 @@
from __future__ import annotations
from pathlib import Path
from agent.app import load_application
from agent.commands import (
CommandCoordinator,
CommandOriginKind,
CommandRequest,
CommandResult,
CommandState,
CommandTargetKind,
)
from agent.core import event_envelope_to_record
from agent.core.enums import EventKind, PayloadKind, Severity, SourceKind
from agent.derivator import (
DerivatorWorker,
WifiScanSummaryWorkflow,
WifiScanSummaryWorkflowConfig,
)
from agent.proto_generated import common_pb2, events_pb2
from agent.proto_helpers import make_event_envelope
ROOT = Path(__file__).resolve().parents[2]
FIXTURES = ROOT / "tests" / "fixtures"
class _RecordingRouter:
def __init__(self) -> None:
self.calls: list[str] = []
def supports(self, request: CommandRequest) -> bool:
return request.command_type.startswith("wpa.")
def execute(self, request: CommandRequest) -> CommandResult:
self.calls.append(request.command_id)
return CommandResult.from_request(
request,
state=CommandState.SUCCEEDED,
accepted=True,
success=True,
message=f"ok:{request.command_id}",
executor_name="router",
started_mono_ns=1,
finished_mono_ns=2,
)
def _wifi_envelope(*, event_id: str, event_type: str, event_line: str) -> events_pb2.EventEnvelope:
return make_event_envelope(
id=event_id,
source="wpa-supplicant",
type=event_type,
subject="wlp3s0",
event_kind=common_pb2.EVENT_KIND_RAW,
source_kind=common_pb2.SOURCE_KIND_WPA_CTRL,
severity=common_pb2.SEVERITY_INFO,
routing=events_pb2.RoutingDirectives(
cache_enabled=True, outbox_enabled=False, priority=7
),
trace=events_pb2.TraceContext(workflow_tags=["wifi", "wpa"]),
normalized_event_code=event_line,
normalized_reason="disconnect",
payload=events_pb2.RawWpaPayload(
interface_name="wlp3s0",
event_line=event_line,
event_name=event_line,
key_values={"iface": "wlp3s0"},
),
payload_field="raw_wpa",
)
def _seed_wifi_event(app) -> None:
envelope = _wifi_envelope(
event_id="evt-1",
event_type="wifi.raw.wpa.disconnected",
event_line="CTRL-EVENT-DISCONNECTED",
)
app._ingest_envelope(envelope, origin="collector", now_mono_ns_value=100)
def test_derivator_worker_routes_derived_envelope_through_director() -> None:
app = load_application(config_path=FIXTURES / "cli-basic.toml", load_env_file=False)
_seed_wifi_event(app)
workflow = WifiScanSummaryWorkflow()
worker = DerivatorWorker(
app.cache,
event_sink=app._on_derived_envelope,
command_sink=app._submit_derivator_command,
workflows=(workflow,),
poll_interval_ms=0,
)
result = worker.poll_once(now_mono_ns_value=200)
assert result.polled is True
assert result.derived_total == 1
assert app.cache.head(2).records[-1].type == "wifi.derived.scan_summary"
assert app.outbox.stats().size == 1
records = app.ingest_trace.snapshot().records
assert any(record.get("origin") == "derivator" for record in records)
assert any(record["stage"] == "director.cache.append" for record in records)
assert any(record["stage"] == "director.outbox.enqueue" for record in records)
def test_derivator_worker_routes_follow_up_command_through_coordinator() -> None:
app = load_application(config_path=FIXTURES / "cli-basic.toml", load_env_file=False)
_seed_wifi_event(app)
router = _RecordingRouter()
app.command_coordinator_runtime = CommandCoordinator(
router=router,
sink=app._on_command_result,
)
workflow = WifiScanSummaryWorkflow(
WifiScanSummaryWorkflowConfig(
follow_up_command_type="wpa.signal_poll",
follow_up_command_target_kind=CommandTargetKind.WPA_CTRL,
follow_up_command_target_id="wlp3s0",
follow_up_command_min_disconnects=1,
follow_up_command_dedup_key="wifi_scan_summary:wlp3s0:signal_poll",
follow_up_command_cooldown_key="wifi_scan_summary:wlp3s0:signal_poll",
)
)
worker = DerivatorWorker(
app.cache,
event_sink=app._on_derived_envelope,
command_sink=app._submit_derivator_command,
workflows=(workflow,),
poll_interval_ms=0,
)
result = worker.poll_once(now_mono_ns_value=300)
assert result.polled is True
assert result.derived_total == 1
assert app.command_state().stats.received_total == 1
assert router.calls == ["derivator:wifi_scan_summary:1:1:wpa-signal_poll"]
assert app.cache.tail(3).records[0].type == "wifi.derived.scan_summary"
assert app.cache.tail(3).records[1].type == "control.command.started"
assert app.cache.tail(3).records[2].type == "control.command.succeeded"
assert app.outbox.stats().size == 3